Import closure not directory sweep

Platform spec ADR

Import closure not directory sweep

Back to Program assembly ◎ Open feature in platform map

Spec standingStandard

Owner

Piotr Mikstacki pmikstacki@cybernomad.it

Submitter

Piotr Mikstacki pmikstacki@cybernomad.it

Current document

Articles

• Program assembly - Contracts and edge cases Materialized-first roots, discovery caps, and parity across CLI and LSP. article Standard Reviewed Wed May 20
• Program assembly - Design model EffectiveCompilationRoots, ProgramAssembly, ModuleIndex, and hybrid discovery modes. article Standard Reviewed Fri May 29
• Program assembly - Flow and algorithm Ordered assembly after workspace materialize and before multi-unit parse and HIR resolution. article Standard Reviewed Wed May 20
• Program assembly - Verification and traceability Test and source anchors for ProgramAssembly and effective roots. article Standard Reviewed Wed May 20

History

0 revisions (git unavailable at build; counts may be empty)

Open full history on GitHub

No commits recorded for this path.

Completeness

OKfeature · 0 SpecSection(s) · 1 H2 heading(s)

Full tree: run pnpm verify:platform-spec-layout (writes src/generated/platform-spec-layout-report.json).

Related spec docs

• Feature
  Program assembly

  Parent feature hub

• Feature
  Dependency prelude union seeding

  Prelude seeds into closure

Context

ImportClosure and WorkspaceScan modes were conflated in places: directory sweeps pulled unrelated .bd files into compile graphs, breaking determinism and parity with explicit use graphs.

Decision

For AssemblyDiscovery::ImportClosure (build, run, lower, test, LSP document snapshots):

Rule	Detail
Seeds	Entry file, prelude union seeds (D-COMP-BUILD-0022), and each pub mod A.B resolve exactly one module file before traversal
Expansion	Additional units enter the queue only when a queued file contains a use import that resolves under effective roots
No sweep	ImportClosure must not enumerate all *.bd under roots (that mode is WorkspaceScan only, for LSP workspace indexing)

WorkspaceScan remains capped by max_units with deterministic sort; it must not be used for beskid build / beskid run / beskid test.

Consequences

Assembly unit count tracks the transitive use graph plus explicit prelude seeds. Tests assert closure size for fixture projects.

Verification anchors

• compiler/crates/beskid_analysis/src/projects/assembly/loader.rs
• compiler/crates/beskid_analysis/src/projects/model.rs (AssemblyDiscovery)
• compiler/crates/beskid_tests/src/projects/composition.rs